Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ada-mode 8.1.0, gpr-mode 1.0.4 and dependencies #905

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Release ada-mode 8.1.0, gpr-mode 1.0.4 and dependencies #905

merged 7 commits into from
Oct 14, 2023

Conversation

stephe-ada-guru
Copy link
Contributor

No description provided.

@stephe-ada-guru
Copy link
Contributor Author

The windows build is failing with:

s-memory.adb:1:79: (style) incorrect line terminator

It seems gnat 13 is now trying to enforce "correct" line terminators on files, which is just ridiculous; always accepting either Unix or DOS is far more friendly, and not at all harmful.

According to the gnat 13 user guide gnat_ug.info, there is no way to turn off this check.

I searched for this issue, and found AdaCore/Ada_Drivers_Library#43, which says that the solution is a git config setting to get the line endings right. That has to be done in the github task that is running this check.

@stephe-ada-guru
Copy link
Contributor Author

I tried to reproduce the issue on my Windows box by deleting "autoclrf = false" from my ~/.gitconfig, but that had no effect; wisitoken crate built fine either way.

@stephe-ada-guru
Copy link
Contributor Author

I managed to reproduce the compiler error; it is reported when s-memory.adb has DOS line endings, which happens when ~/.gitconfig has autocrlf = true. Apparently the gnat style switch -gnatyd is set when compiling that file (it has different compiler switches than the other files). But that's not new in gnat 13, so this must have changed in the .gitconfig used for this test. I'll try adding a .gitattributes setting for that file.

@stephe-ada-guru
Copy link
Contributor Author

I managed to reproduce the compiler error; it is reported when s-memory.adb has DOS line endings, which happens when ~/.gitconfig has autocrlf = true. Apparently the gnat style switch -gnatyd is set when compiling that file (it has different compiler switches than the other files). But that's not new in gnat 13, so this must have changed in the .gitconfig used for this test. I tried adding .gitattributes to prevent git from messing with the line termination, but that did not work. So I added a pre-build action.

@stephe-ada-guru
Copy link
Contributor Author

Now the prebuild action that runs dos2unix is failing on non-Windows, probably because it is not installed? How do I make that action only on Windows?

@stephe-ada-guru
Copy link
Contributor Author

Fixed the line ending problem. Now Windows is failing when it runs the ada-mode pre-build function, which runs wisitoken-bnf-generate, which can take a large amount of memory. So I'm guessing the failure is due to limited memory. The other builds succeed; do they have more memory, or is Windows just less efficient? In either case, the best solution is to increase the memory for that machine. I could do a workaround where I store the results of that run on Savannah, and change the pre-build action to just copy them, but that's a kludge.

@mosteo
Copy link
Member

mosteo commented Oct 10, 2023

If you're confident that things are OK, we can merge as-is, let me know if so.

As for a permanent solution, I will check if we're able to increase memory of Windows VMs.

@mosteo
Copy link
Member

mosteo commented Oct 10, 2023

The free Windows machines have 7GB of RAM. Anything beyond requires pay-per-use :S

@stephe-ada-guru
Copy link
Contributor Author

Please merge; everything works fine on my Windows machine

@stephe-ada-guru
Copy link
Contributor Author

Please merge; everything works fine on my Windows box.

@mosteo mosteo merged commit c460cca into alire-project:stable-1.2.1 Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants